Add @legendecas to approvers / CODEOWNERS #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
dyladan,
markwolff,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
naseemkullah
approved these changes
Jun 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 92.17% 92.17%
=======================================
Files 120 120
Lines 3410 3410
Branches 697 697
=======================================
Hits 3143 3143
Misses 267 267 |
markwolff
approved these changes
Jun 15, 2020
|
🎉 Thank you! |
vmarchaud
approved these changes
Jun 16, 2020
dyladan
approved these changes
Jun 16, 2020
mwear
approved these changes
Jun 16, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: ignore packages that don't work on node@18 * chore: enable running TAV on PRs * chore: filter out scopes that don't have test-all-versions script * chore: remove checklist with the reminder to run TAV * chore: remove unneeded containers from tav jobs * chore: sort keys * chore: skip more tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given his regular contribution to OpenTelemetry JS, propose that @legendecas is granted Approver status.
Background:
/cc @legendecas