Increase Test Coverage for XML Http Plugin #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tina Gao <thgao@uwaterloo.ca>
added test for when request url is an ignored url from plugin config
fix header propagation tests that were affected by added a preflight span
Added tests for clearTimingResources setting in the plugin's config for the default behaviour when unspecified (false) and for explicitly setting to true.
thgao
requested review from
bg451,
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
+ Coverage 92.32% 93.20% +0.87%
==========================================
Files 122 122
Lines 3533 3533
Branches 714 714
==========================================
+ Hits 3262 3293 +31
+ Misses 271 240 -31
|
mayurkale22
approved these changes
Jun 19, 2020
|
@open-telemetry/javascript-approvers Please take a look when you get a chance. |
dyladan
approved these changes
Jun 22, 2020
naseemkullah
approved these changes
Jun 22, 2020
markwolff
approved these changes
Jun 22, 2020
mayurkale22
added
enhancement
obecny
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes