Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-core): modify regex to allow future versions #1269

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

srjames90
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Modifies the VALID_TRACE_PARENT_REGEX to allow for future versions excluding FF

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 1, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #1269 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files         131      131           
  Lines        3696     3696           
  Branches      747      747           
=======================================
  Hits         3438     3438           
  Misses        258      258           
Impacted Files Coverage Δ
...y-core/src/context/propagation/HttpTraceContext.ts 100.00% <100.00%> (ø)

@srjames90
Copy link
Contributor Author

I signed it

@dyladan
Copy link
Member

dyladan commented Jul 1, 2020

@srjames90 there is no need to fix the cla/linuxfoundation error. EasyCLA is our new CLA tool and the old one is deprecated.

@srjames90
Copy link
Contributor Author

@srjames90 there is no need to fix the cla/linuxfoundation error. EasyCLA is our new CLA tool and the old one is deprecated.

Oh, lol thanks

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @srjames90!

@dyladan dyladan merged commit a557b04 into open-telemetry:master Jul 1, 2020
@dyladan dyladan added the bug Something isn't working label Jul 1, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpTraceContext requires version 00
5 participants