Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: force flush and shutdown callback for span exporters #1296

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Jul 9, 2020

Fixes #1295 and is related to #1290

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1296 into master will decrease coverage by 0.02%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   93.24%   93.21%   -0.03%     
==========================================
  Files         137      133       -4     
  Lines        3878     3891      +13     
  Branches      790      801      +11     
==========================================
+ Hits         3616     3627      +11     
- Misses        262      264       +2     
Impacted Files Coverage Δ
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 42.85% <0.00%> (-17.15%) ⬇️
...elemetry-tracing/src/export/SimpleSpanProcessor.ts 82.35% <80.00%> (+3.78%) ⬆️
...telemetry-tracing/src/export/BatchSpanProcessor.ts 92.15% <81.81%> (-3.59%) ⬇️
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts 90.90% <83.33%> (-9.10%) ⬇️
...elemetry-semantic-conventions/src/trace/general.ts
...lemetry-semantic-conventions/src/trace/database.ts
...entelemetry-semantic-conventions/src/trace/http.ts
...pentelemetry-semantic-conventions/src/trace/rpc.ts

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just please fix the import vs require for sinon

@obecny
Copy link
Member

obecny commented Jul 10, 2020

Just looking at coverage it would be good to add more unit tests

@mayurkale22 mayurkale22 added the Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jul 12, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS lambda - process is killed before the span is being exported
7 participants