Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api/context-base): change compile target to es5 #1368

Merged
merged 1 commit into from
Jul 31, 2020
Merged

feat(api/context-base): change compile target to es5 #1368

merged 1 commit into from
Jul 31, 2020

Conversation

markwolff
Copy link
Member

@markwolff markwolff commented Jul 29, 2020 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Downgrade compile target of @opentelemetry/api & @opentelemetry/context-base (dependency of /api) es2017 ... es5

@markwolff markwolff mentioned this pull request Jul 29, 2020
Closed
2 tasks
@dyladan
Copy link
Member

dyladan commented Jul 29, 2020 •
edited
Loading

Differences I have noticed between this and ES2017 (current).

  • No use of class keyword
  • Use of var instead of const and let
  • No use of arrow functions

Use of Symbol, global, and globalThis appears to be unchanged.

@codecov
Copy link

codecov bot commented Jul 29, 2020 •
edited
Loading

Codecov Report

Merging #1368 into master will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   93.18%   93.61%   +0.42%     
==========================================
  Files         149      149              
  Lines        4228     4259      +31     
  Branches      869      869              
==========================================
+ Hits         3940     3987      +47     
+ Misses        288      272      -16
Impacted Files Coverage Δ
packages/opentelemetry-api/src/trace/NoopSpan.ts 100.00% <0.00%> (ø)
packages/opentelemetry-api/src/trace/NoopTracer.ts 100.00% <0.00%> (ø)
...opentelemetry-api/src/metrics/NoopMeterProvider.ts 100.00% <0.00%> (ø)
...entelemetry-context-base/src/NoopContextManager.ts 100.00% <0.00%> (ø)
packages/opentelemetry-api/src/api/trace.ts 90.90% <0.00%> (+5.19%) ⬆️
packages/opentelemetry-api/src/api/context.ts 83.87% <0.00%> (+8.87%) ⬆️
packages/opentelemetry-api/src/api/propagation.ts 55.88% <0.00%> (+9.21%) ⬆️
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 80.30% <0.00%> (+12.37%) ⬆️
packages/opentelemetry-context-base/src/context.ts 77.77% <0.00%> (+13.07%) ⬆️
packages/opentelemetry-api/src/api/metrics.ts 63.63% <0.00%> (+16.01%) ⬆️
... and 2 more

@mayurkale22 mayurkale22 merged commit 023541e into open-telemetry:master Jul 31, 2020
@xirzec xirzec mentioned this pull request Jul 31, 2020
Closed
5 tasks
@ramya-rao-a
Copy link

Can anyone share when we can expect this fix to be released in an update to the package?

@dyladan
Copy link
Member

dyladan commented Aug 3, 2020

Are you waiting for this feature in particular? If so, we can probably push a release through fairly soon.

@ramya-rao-a
Copy link

Yes please :)

@dyladan dyladan added the enhancement New feature or request label Aug 3, 2020
@dyladan
Copy link
Member

dyladan commented Aug 3, 2020

Yes please :)

#1382 :)

@ramya-rao-a ramya-rao-a mentioned this pull request Aug 4, 2020
Merged
@dyladan dyladan mentioned this pull request Aug 4, 2020
Merged
jonahrosenblum pushed a commit to jonahrosenblum/opentelemetry-js that referenced this pull request Aug 8, 2020
@markwolff @jonahrosenblum
feat(api/context-base): change compile target to es5 (open-telemetry#…
0a0a487 
…1368)
obecny added a commit that referenced this pull request Aug 17, 2020
@jonahrosenblum @dyladan
@obecny @aravinsiva @rubenvp8510 @mayurkale22 @naseemkullah @legendecas @markwolff @mwear @EdZou @reggiemcdonald @renovate-bot @srjames90 @davidwitten @mickdekkers
Add Graceful Shutdown Support (#1321)
b884eec 
* feat: graceful shutdown for tracing and metrics

* fix: wording in test case

* fix: typo

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix meterprovider config to use bracket notation

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: add callbacks to shutdown methods

* fix: merge conflict

* simplify meter shutdown code

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: fix one-liner

* private function name style fix

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: naming of private member variables

* fix: graceful shutdown now works in browser

* fix: window event listener will trigger once

* fix: modify global shutdown helper functions

* fix: remove callback from remove listener args

* fix: change global shutdown function names and simplify functionality

* fix: add rest of function refactoring and simplification

* fix: remove unintended code snippet

* fix: refactor naming of listener cleanup function and fix sandbox issue

* fix: make global shutdown cleanup local

* fix: change interval of MeterProvider collection to ensure it does not trigger through clock

* chore: removing _cleanupGlobalShutdownListeners

* fix: remove unnecesary trace provider member function

* Removing default span attributes (#1342)

* refactor(opentelemetry-tracing): removing default span attributes

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing default span attributed from tracer object

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing accidental add to package.json

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel

Signed-off-by: Aravin Sivakumar <aravinarjunn@gmail.com>

* feat: add baggage support to the opentracing shim (#918)

Co-authored-by: Mayur Kale <mayurkale@google.com>

* Add nodejs sdk package (#1187)

Co-authored-by: Naseem <naseemkullah@gmail.com>
Co-authored-by: legendecas <legendecas@gmail.com>
Co-authored-by: Mark Wolff <mrw00010@gmail.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>

* feat: add OTEL_LOG_LEVEL env var (#974)

* Proto update to latest to support arrays and maps (#1339)

* chore: 0.10.0 release proposal (#1345)

* fix: add missing grpc-js index (#1358)

* chore: 0.10.1 release proposal (#1359)

* feat(api/context-base): change compile target to es5 (#1368)

* Feat: Make ID generator configurable (#1331)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* fix: require grpc-js instead of grpc in grpc-js example (#1364)

Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>

* chore(deps): update all non-major dependencies (#1371)

* chore: bump metapackage dependencies (#1383)

* chore: 0.10.2 proposal (#1382)

* fix: remove unnecesary trace provider member function

* refactor(metrics): distinguish different aggregator types (#1325)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* Propagate b3 parentspanid and debug flag (#1346)

* feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* feat: Collector Metric Exporter for the Web (#1308)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* Fix issues in TypeScript getting started example code (#1374)

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>

* chore: deploy canary releases (#1384)

* fix: protos pull

* fix: address marius' feedback

* chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier

* fix: add documentation and cleanup code

* fix: remove async label from shutdown and cleanup test case

* fix: update controller collect to return promise

* fix: make downsides of disabling graceful shutdown more apparent

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
Co-authored-by: Aravin <34178459+aravinsiva@users.noreply.github.com>
Co-authored-by: Ruben Vargas Palma <ruben.vp8510@gmail.com>
Co-authored-by: Mayur Kale <mayurkale@google.com>
Co-authored-by: Naseem <naseemkullah@gmail.com>
Co-authored-by: legendecas <legendecas@gmail.com>
Co-authored-by: Mark Wolff <mrw00010@gmail.com>
Co-authored-by: Matthew Wear <matthew.wear@gmail.com>
Co-authored-by: Naseem <naseem@transit.app>
Co-authored-by: Mark Wolff <mark.wolff@microsoft.com>
Co-authored-by: Cong Zou <32532612+EdZou@users.noreply.github.com>
Co-authored-by: Reginald McDonald <40721169+reggiemcdonald@users.noreply.github.com>
Co-authored-by: WhiteSource Renovate <bot@renovateapp.com>
Co-authored-by: srjames90 <srjames@lightstep.com>
Co-authored-by: David W <dwitt12345@gmail.com>
Co-authored-by: Mick Dekkers <mickdekkersnl@gmail.com>
@markwolff markwolff deleted the api/use-es5 branch November 15, 2020 07:28
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@markwolff @dyladan
feat(api/context-base): change compile target to es5 (open-telemetry#…
cc6286a 
…1368)
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@markwolff @dyladan
feat(api/context-base): change compile target to es5 (open-telemetry#…
b236770 
…1368)
@mdbudnick mdbudnick mentioned this pull request Sep 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@naseemkullah naseemkullah naseemkullah approved these changes

@legendecas legendecas Awaiting requested review from legendecas

@mwear mwear Awaiting requested review from mwear

@obecny obecny Awaiting requested review from obecny

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What about IE11 support?
6 participants
@markwolff @dyladan @ramya-rao-a @vmarchaud @mayurkale22 @naseemkullah