Feat: added AWS ECS Plugins resource detector #1403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdZou
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Added AWS ECS plugins resource detector.
Short description of the changes
Explanation of this part can be referred to issue I opened: Add container ID attribute for Resource constants #1394
Since there is no response, I just add this part and made a PR.
If you would like to review @dyladan @anuraaga
Really appreciate it!
A Question for ECS and Beanstalk detector PRs
Since we have decided to put vendor's resource detector to js-contrib repository:
I am not so sure when will these code be moved to js-contrib and my internship has limited time to go.
May we first merge these PRs so we could move them together to js-contrib afterwards?