Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing semantic conventions from code coverage #1409

Merged
merged 2 commits into from
Aug 10, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Aug 7, 2020

removing semantic conventions from code coverage
We don't need code coverage for just semantic stuff - otherwise this is misleading

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #1409 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1409      +/-   ##
==========================================
+ Coverage   94.03%   94.04%   +0.01%     
==========================================
  Files         149      143       -6     
  Lines        4322     4268      -54     
  Branches      880      866      -14     
==========================================
- Hits         4064     4014      -50     
+ Misses        258      254       -4     
Impacted Files Coverage Δ
...elemetry-semantic-conventions/src/trace/general.ts
...lemetry-semantic-conventions/src/trace/database.ts
packages/opentelemetry-plugin-https/src/utils.ts
...pentelemetry-semantic-conventions/src/trace/rpc.ts
...entelemetry-semantic-conventions/src/trace/http.ts
packages/opentelemetry-plugin-https/src/https.ts

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @vmarchaud please remove the codecov script altogether.

packages/opentelemetry-semantic-conventions/package.json Outdated Show resolved Hide resolved
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to provide LGTM and hope you can address @vmarchaud's comment prior to merging.

@obecny obecny force-pushed the semantic_conventions_codecov branch from 5232038 to d5eadf4 Compare August 10, 2020 18:20
@dyladan dyladan merged commit 43d01dd into open-telemetry:master Aug 10, 2020
@obecny obecny deleted the semantic_conventions_codecov branch October 1, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants