Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add missing prometheus exports for ValueRecorder, SumObserver & UpDownSumObserver #1428

Merged
merged 6 commits into from
Aug 17, 2020
Merged

feat: Add missing prometheus exports for ValueRecorder, SumObserver & UpDownSumObserver #1428

merged 6 commits into from
Aug 17, 2020

Conversation

paulfairless
Copy link
Contributor

Which problem is this PR solving?

Adds missing support for ValueRecorder, SumObserver & UpDownSumObserver in the prometheus exporter.

Short description of the changes

  • use counter for SumObserver, gauge for UpDownSumObserver & ValueRecorder
  • unit tests following existing conventions

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 14, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Aug 14, 2020 •
edited
Loading

Codecov Report

Merging #1428 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1428   +/-   ##
=======================================
  Coverage   94.11%   94.12%           
=======================================
  Files         145      145           
  Lines        4335     4341    +6     
  Branches      883      886    +3     
=======================================
+ Hits         4080     4086    +6     
  Misses        255      255
Impacted Files Coverage Δ
...pentelemetry-exporter-prometheus/src/prometheus.ts 90.47% <100.00%> (+0.57%) ⬆️

obecny
obecny approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/opentelemetry-exporter-prometheus/test/prometheus.test.ts Outdated Show resolved Hide resolved
dyladan
dyladan approved these changes Aug 14, 2020
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@dyladan dyladan added the enhancement New feature or request label Aug 17, 2020
@dyladan dyladan merged commit 2916ecf into open-telemetry:master Aug 17, 2020
@legendecas legendecas mentioned this pull request Aug 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@dyladan dyladan dyladan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@legendecas legendecas legendecas approved these changes

@markwolff markwolff Awaiting requested review from markwolff

@mayurkale22 mayurkale22 Awaiting requested review from mayurkale22

@mwear mwear Awaiting requested review from mwear

@naseemkullah naseemkullah Awaiting requested review from naseemkullah

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulfairless @obecny @dyladan @vmarchaud @legendecas