Move SpanContext isValid to the API #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1447 +/- ##
=======================================
Coverage 93.99% 93.99%
=======================================
Files 153 153
Lines 4663 4666 +3
Branches 962 963 +1
=======================================
+ Hits 4383 4386 +3
Misses 280 280
|
srjames90
force-pushed
the
span-context-is-valid
branch
from
01a7e21
to
9c34b01
Compare
srjames90
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
dyladan
reviewed
Aug 21, 2020
xirzec
reviewed
Aug 21, 2020
srjames90
commented
Aug 24, 2020
srjames90
commented
Aug 24, 2020
srjames90
force-pushed
the
span-context-is-valid
branch
from
4f31b28
to
2221074
Compare
|
The spec suggests adding a helper function. open-telemetry/opentelemetry-specification#771 (comment) @srjames90 can you implement Making changes to the ~30 callers is fine. |
Cool, sounds good. Sounds like the current changes are fine, and just have to rename the function. Thanks, will do it now. |
dyladan
requested changes
Aug 26, 2020
packages/opentelemetry-core/src/context/propagation/B3Propagator.ts
Outdated
Show resolved
Hide resolved
dyladan
approved these changes
Aug 26, 2020
|
Looks like @srjames90 put the function at |
@srjames90 pls move the function to |
dyladan
reviewed
Aug 26, 2020
markwolff
approved these changes
Aug 27, 2020
vmarchaud
approved these changes
Aug 30, 2020
obecny
approved these changes
Aug 31, 2020
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* refactor: make spanContext into class with isValid * refactor: use class instantiation for spanContext * refactor: moves test and fix tests * fix: add check for isValid * revert: the changes to spanContext * refactor: move spancontext-utils to api package * fix: lint and invalid psan id and invalid trace id * fix: make isValid more robust * refactor: rename isValid to isSpanContextValid * refactor: update regex and checks * fix: export isSpanContextValid from api.trace * fix: run npm run lint:fix * fix: run lint fix in api * refactor: prevent function overhead * fix: lint * fix: remove unused import Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* refactor: make spanContext into class with isValid * refactor: use class instantiation for spanContext * refactor: moves test and fix tests * fix: add check for isValid * revert: the changes to spanContext * refactor: move spancontext-utils to api package * fix: lint and invalid psan id and invalid trace id * fix: make isValid more robust * refactor: rename isValid to isSpanContextValid * refactor: update regex and checks * fix: export isSpanContextValid from api.trace * fix: run npm run lint:fix * fix: run lint fix in api * refactor: prevent function overhead * fix: lint * fix: remove unused import Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Fixes #1414
Short description of the changes
Changes SpanContext interface to a class and adds an isValid method to it. This also updates every reference to SpanContext to instantiate the spanContext using new instead of an object literal matching the interface.
Started as draft in case this isn't what we had in mind since it ends up changing so many files. I had to go through so many files because the interfaces were being implemented with object literals.