refactor: Update nock version and migrate broken tests #1504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This pull request closes issue #1303.
Short description of the changes
nock
fromdependencies
todevDependencies
in@opentelemetry/sdk-node
(it is a test dependency).12.0.3
to13.0.4
(latest version) in 9 packages.nock.Interceptor.socketDelay()
withnock.Interceptor.delayConnection()
.nock
no longer emits asocket hang up
error on request abort and it closes connection inmediately after writing the response, so I had to replace anock
with a manual mock (built withhttp.createServer
[1]) to simulateaborted
event.[1] A
server
was already running onserverPort
because of previous tests (Seehttp-enable.test.ts > HttpPlugin > enable > with good plugin options > before
), so I chose to start a new server instead of rewriting all the previous tests.