Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: variable names cleanup #1536

Merged
merged 4 commits into from
Sep 22, 2020
Merged

Conversation

DarkPurple141
Copy link
Contributor

Which problem is this PR solving?

Found this example to be slightly confusing.

Short description of the changes

Variable names in the trace example were not fully clear. This meant that the relationships between different operations also was unclear. Have amended accordingly.

Variable names in the trace example were not fully clear. This meant that the relationships between different operations also was unclear. Have amended.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 16, 2020

CLA Check
The committers are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1536 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1536   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files         155      155           
  Lines        4811     4811           
  Branches      971      971           
=======================================
  Hits         4480     4480           
  Misses        331      331           

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the change

@dyladan dyladan added the document Documentation-related label Sep 21, 2020
@dyladan dyladan merged commit bc9244f into open-telemetry:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants