New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure CircleCI workflows #155
Conversation
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
+ Coverage 93.84% 98.78% +4.93%
==========================================
Files 41 41
Lines 3282 3282
Branches 385 385
==========================================
+ Hits 3080 3242 +162
+ Misses 202 40 -162
|
command: yarn codecov | ||
node8: | ||
docker: | ||
- image: node:8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the node docker images that don't have browsers installed, we will need a separate test command (or environment variable) to disable the browser tests, since they run on yarn test
, see
"test": "yarn test:node && yarn test:browser", |
Maybe we need yarn test:node
and yarn run test:browser
and segment the tests in this file by that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea, made the appropriate changes in the config file. ptal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Now the Node and browser tests can also run in parallel!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know nothing about browser testing so going to defer on that front, but the rest looks good!
59241d7
to
eabe171
Compare
c8 is supported on Node.js >= 10.12.0, looks like we need to fallback to Any thoughts? |
command: yarn codecov | ||
node8: | ||
docker: | ||
- image: node:8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Now the Node and browser tests can also run in parallel!
Can we just disable coverage reporting for Node 8? I would assume the coverage would be the same as other Node versions (assuming no version-specific branching). |
I would say there are 2 options:
|
9a4dd6b
to
f362022
Compare
Tests and coverage are running with |
@markwolff FYI. For now, I have changed to |
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Closes #50