-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement parent based sampler #1577
Merged
dyladan
merged 11 commits into
open-telemetry:master
from
dynatrace-oss-contrib:parent-or-else
Oct 13, 2020
Merged
feat: implement parent based sampler #1577
dyladan
merged 11 commits into
open-telemetry:master
from
dynatrace-oss-contrib:parent-or-else
Oct 13, 2020
+214
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1577 +/- ##
==========================================
+ Coverage 88.47% 91.41% +2.93%
==========================================
Files 116 165 +49
Lines 2387 5055 +2668
Branches 447 1035 +588
==========================================
+ Hits 2112 4621 +2509
- Misses 275 434 +159
|
vmarchaud
approved these changes
Oct 7, 2020
legendecas
reviewed
Oct 7, 2020
packages/opentelemetry-core/src/trace/sampler/ParentBasedSampler.ts
Outdated
Show resolved
Hide resolved
legendecas
reviewed
Oct 8, 2020
packages/opentelemetry-core/src/trace/sampler/ParentBasedSampler.ts
Outdated
Show resolved
Hide resolved
obecny
reviewed
Oct 9, 2020
packages/opentelemetry-core/src/trace/sampler/ParentBasedSampler.ts
Outdated
Show resolved
Hide resolved
packages/opentelemetry-core/src/trace/sampler/ParentBasedSampler.ts
Outdated
Show resolved
Hide resolved
obecny
approved these changes
Oct 9, 2020
mwear
approved these changes
Oct 12, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1455