-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opentelemetry-js): add content size attributes to HTTP spans #1625
Conversation
Signed-off-by: Carlo Pearson <cpearson@newrelic.com>
Signed-off-by: Carlo Pearson <cpearson@newrelic.com>
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
==========================================
+ Coverage 91.94% 91.98% +0.03%
==========================================
Files 167 167
Lines 5573 5599 +26
Branches 1186 1193 +7
==========================================
+ Hits 5124 5150 +26
Misses 449 449
|
Still waiting on this update #1625 (comment) Also, there are now conflicts. |
Hey @dyladan , we pushed up some changes last Thursday and resolved the conflicts. Please take a look at our changes. |
@open-telemetry/javascript-approvers lets get this reviewed as it is one of the last things we have for GA |
So, there was some concern that if the content encoding header was |
Any update? |
Still good-to-go, waiting on review |
@open-telemetry/javascript-approvers can I get one more ✔️ here? |
Good catches @obecny, working on an update now |
Just pushed a commit to make changes requested by @obecny |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please don't force push after 1st review as it is impossible to see changes then, thx
retriggering |
retriggering |
the same thing needs to be create for http instrumentation -> #1740 (in separate PR) |
Which problem is this PR solving?
Short description of the changes