Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use performance directly in xhr plugin #1651

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 4, 2020

unblocks #1451

Latest version of @types/node does not have performance.getEntriesByType(), but it still exists in the browser global performance.

Using performance directly is safe in the xhr plugin because it will not be used in node.

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #1651 (342ef9f) into master (25a2f65) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1651   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         165      165           
  Lines        5042     5042           
  Branches     1040     1040           
=======================================
  Hits         4606     4606           
  Misses        436      436           
Impacted Files Coverage Δ
...emetry-instrumentation-xml-http-request/src/xhr.ts 96.72% <100.00%> (ø)

@dyladan dyladan added the enhancement New feature or request label Nov 10, 2020
@dyladan dyladan merged commit 894c8d8 into master Nov 10, 2020
@dyladan dyladan deleted the use-performance branch November 10, 2020 20:18
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants