Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename CorrelationContext to Baggage #1687

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 18, 2020

Fixes #1686

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1687 (2e32a33) into master (e032feb) will decrease coverage by 0.02%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
- Coverage   92.17%   92.14%   -0.03%     
==========================================
  Files         167      166       -1     
  Lines        5597     5592       -5     
  Branches     1193     1193              
==========================================
- Hits         5159     5153       -6     
- Misses        438      439       +1     
Impacted Files Coverage Δ
...ckages/opentelemetry-api/src/baggage/EntryValue.ts 100.00% <ø> (ø)
...s/opentelemetry-tracing/src/BasicTracerProvider.ts 77.77% <ø> (ø)
packages/opentelemetry-api/src/context/context.ts 92.00% <66.66%> (-8.00%) ⬇️
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts 82.85% <100.00%> (-0.25%) ⬇️
...emetry-core/src/baggage/propagation/HttpBaggage.ts 98.11% <100.00%> (ø)
...ackages/opentelemetry-shim-opentracing/src/shim.ts 87.70% <100.00%> (ø)
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 88.15% <0.00%> (+1.31%) ⬆️

GA Burndown automation moved this from In progress PRs to Approved Nov 25, 2020
@obecny obecny added the enhancement New feature or request label Dec 14, 2020
@obecny
Copy link
Member

obecny commented Dec 14, 2020

@dyladan tests failed again, pls have a look

@obecny obecny merged commit b744f30 into open-telemetry:master Dec 14, 2020
GA Burndown automation moved this from Approved to Done Dec 14, 2020
@dyladan dyladan deleted the context-baggage-rename branch December 14, 2020 21:01
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: rename CorrelationContext to Baggage

* chore: lint
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: rename CorrelationContext to Baggage

* chore: lint
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging this pull request may close these issues.

Rename CorrelationContext to Baggage
4 participants