fix(xhr): check for resource timing support #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrosty
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
bradfrosty
force-pushed
the
observer-check-entrytype
branch
from
98f27bb
to
d3e6fbf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 165 165
Lines 5138 5141 +3
Branches 1056 1059 +3
=======================================
+ Hits 4694 4697 +3
Misses 444 444
|
|
@dyladan I was confused for a bit, because I was referring to that caniuse link as well. However, that page is not entirely accurate. In the issue description I link to a more accurate caniuse for resource timing support. So it shows that it's supported in Safari 11, but only beyond macOS 10.12+. So in a sense, I guess we're trying to target a specific browser version AND OS version. We have a significant number of users still using Safari 11 on macOS 10.11 (57k errors reported in last 24 hours). The reported browser and OS for these errors is 100% on this specific browser/OS combination. |
vmarchaud
approved these changes
Dec 5, 2020
bradfrosty
force-pushed
the
observer-check-entrytype
branch
from
d3e6fbf
to
27c381e
Compare
naseemkullah
pushed a commit
to naseemkullah/opentelemetry-js
that referenced
this pull request
Dec 23, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Amir Blum <amirgiraffe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
PerformanceResourceTimingsupport in@opentelemetry/instrumentation-xml-http-request