-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert fetch plugin to instrumentation #1796
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1796 +/- ##
==========================================
- Coverage 92.49% 92.10% -0.39%
==========================================
Files 173 159 -14
Lines 6019 5169 -850
Branches 1287 1110 -177
==========================================
- Hits 5567 4761 -806
+ Misses 452 408 -44 |
I thought we agreed to keep both plugin and instr until the new loader was ready? |
for node yes, for web it is fully compatible it will have just a different name, see XMLHTTPRequest it is the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great thanks
…metry#1796) Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Which problem is this PR solving?
Short description of the changes