Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint #1992

Merged
merged 2 commits into from
Mar 3, 2021
Merged

chore: update eslint #1992

merged 2 commits into from
Mar 3, 2021

Conversation

Flarna
Copy link
Member

@Flarna Flarna commented Mar 2, 2021

Which problem is this PR solving?

After npm install the package-lock.json was modified because version there is still 0.17.0.

Short description of the changes

Regenerate package-lock.json but when on it I updated eslint + plugins to latest version.

@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #1992 (d846389) into main (1905296) will decrease coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1992      +/-   ##
==========================================
- Coverage   92.85%   92.67%   -0.19%     
==========================================
  Files         139      152      +13     
  Lines        5317     5923     +606     
  Branches     1103     1245     +142     
==========================================
+ Hits         4937     5489     +552     
- Misses        380      434      +54     
Impacted Files Coverage Δ
...async-hooks/src/AsyncLocalStorageContextManager.ts 23.52% <0.00%> (-76.48%) ⬇️
...kages/opentelemetry-node/src/NodeTracerProvider.ts 94.11% <0.00%> (-5.89%) ⬇️
...lemetry-exporter-collector/src/transformMetrics.ts 95.00% <0.00%> (ø)
...ry-exporter-collector/src/CollectorExporterBase.ts 92.30% <0.00%> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <0.00%> (ø)
...rumentation/src/platform/browser/old/autoLoader.ts 100.00% <0.00%> (ø)
packages/opentelemetry-web/src/utils.ts 94.66% <0.00%> (ø)
...kages/opentelemetry-web/src/StackContextManager.ts 97.05% <0.00%> (ø)
...ntelemetry-web/src/enums/PerformanceTimingNames.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts 100.00% <0.00%> (ø)
... and 6 more

@obecny
Copy link
Member

obecny commented Mar 2, 2021

I thought we already agreed to remove all package-lock.json ?

@dyladan
Copy link
Member

dyladan commented Mar 2, 2021

I thought we already agreed to remove all package-lock.json ?

Its removed from API but the PR to remove it here never happened I guess.

@Flarna can you update this PR to just remove it?

edit: nevermind it's not as straightforward as i was thinking since the CI needs to be adapted. i'll do it in another PR

@Flarna Flarna changed the title chore: update eslint and package-lock.json chore: update eslint Mar 3, 2021
@dyladan dyladan merged commit 0935a8e into open-telemetry:main Mar 3, 2021
@Flarna Flarna deleted the update-eslint branch March 3, 2021 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants