Server side rendering support

[ryhinchey]

Which problem is this PR solving?

Running opentelemetry-web in a javascript application that's being server side renderedwill throw an error. This PR fixes that issue as documented here #1575

Short description of the changes

• moves the url normalization done with an anchor tag under a function so it will not be run on import

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Ryan Hinchey (c6199f7, dc1c88d)

[codecov]

Codecov Report

Merging #2010 (4c38385) into main (e5fedbd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4c38385 differs from pull request most recent head b71cfb4. Consider uploading reports for the commit b71cfb4 to get more accurate results

@@           Coverage Diff           @@
##             main    #2010   +/-   ##
=======================================
  Coverage   92.98%   92.98%           
=======================================
  Files         152      152           
  Lines        5926     5934    +8     
  Branches     1245     1247    +2     
=======================================
+ Hits         5510     5518    +8     
  Misses        416      416           

Impacted Files	Coverage Δ
...s/opentelemetry-instrumentation-fetch/src/fetch.ts	99.25% <100.00%> (+0.02%)	⬆️
packages/opentelemetry-web/src/utils.ts	94.80% <100.00%> (+0.13%)	⬆️

[dyladan]

@obecny is there some reason not to use globalThis or similar? Maybe from core we should export something like

export const getGlobal = function () {
  if (typeof globalThis !== 'undefined') { return globalThis; }
  if (typeof self !== 'undefined') { return self; }
  if (typeof window !== 'undefined') { return window; }
  if (typeof global !== 'undefined') { return global; }
  throw new Error('unable to locate global object');
};

[ryhinchey]

yah I think this type of check is a good idea. I didn't use globalThis because I wasn't sure if the browser support was there or not.

I can add a getGlobal function to core. Do you see any other places it's needed besides https://github.com/open-telemetry/opentelemetry-js/blob/main/packages/opentelemetry-core/src/platform/node/environment.ts#L29?

[dyladan]

I wasn't sure if the browser support was there or not.

It's not there in IE at least. I would wait on feedback from @obecny before making changes to core

[obecny]

tbh I don't remember why it is not using global.
@ryhinchey there is already a property for that, but not in the core but in api _globalThis so just use this one.
If there is anything that needs to be changed in this _globalThis then feel free to open PR in api

[obecny]

here -> https://github.com/open-telemetry/opentelemetry-js-api/blob/main/src/platform/browser/globalThis.ts

[ryhinchey]

@obecny sounds good - thanks

[ryhinchey]

now that I think about it, I'll break out the service worker support into a separate PR and keep this one just to server side rendering

[ryhinchey]

Is there anything else that needs to be done to land this? Thanks for the timely reviews!

[dyladan]

Is there anything else that needs to be done to land this? Thanks for the timely reviews!

nope