feat(exporter-collector): support config from env #2099

[vmarchaud]

this is a new PR addressing feedbacks made on #2101. Some changes not directly related to the main issue that i've made:

• I've also changed the default port for HTTP which seems to be 4317 now: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/otlp.md#otlphttp-default-port
• I've exposed utils from baggage propagator to parse a arbitrary string to get key/values to avoid re-implementing the parsing everywhere.

Fixes #2099

[codecov]

Codecov Report

Merging #2117 (4b2033d) into main (5dcec45) will increase coverage by 0.41%.
The diff coverage is 82.22%.

@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
+ Coverage   92.27%   92.69%   +0.41%     
==========================================
  Files         122      141      +19     
  Lines        4066     5037     +971     
  Branches      833     1037     +204     
==========================================
+ Hits         3752     4669     +917     
- Misses        314      368      +54     

Impacted Files	Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts	95.83% <ø> (ø)
packages/opentelemetry-core/src/baggage/utils.ts	74.19% <74.19%> (ø)
...ckages/opentelemetry-core/src/baggage/constants.ts	100.00% <100.00%> (ø)
...e/src/baggage/propagation/HttpBaggagePropagator.ts	96.87% <100.00%> (-1.38%)	⬇️
...kages/opentelemetry-exporter-collector/src/util.ts	100.00% <0.00%> (ø)
...ackages/opentelemetry-web/src/WebTracerProvider.ts	100.00% <0.00%> (ø)
packages/opentelemetry-web/src/types.ts	100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts	85.18% <0.00%> (ø)
...ry-exporter-collector/src/CollectorExporterBase.ts	92.30% <0.00%> (ø)
... and 16 more

[obecny]

Generally looks good to me, thx for changes.
One last thing.
For all different exporter variations the example examples/collector-exporter-node/ is being used.
There is a docker container which can be run and then all collector variations can be tested to see if data is being passed correctly. After changing the default port I can assume it will not be working. Could you please update the docker to ensure it is still working fine (use the latest docker image 0.25)? And as last thing the readme.md in line 8 we have information that the exporter has been tested with a certain version of collector.

Would be nice to update it too then.

[vmarchaud]

After changing the default port I can assume it will not be working. Could you please update the docker to ensure it is still working fine (use the latest docker image 0.25)?

Sure, but i think it would make sense to make test with the collector (end to end pretty much) itself in our pipeline so this doesn't require manual testing in the future

[obecny]

After changing the default port I can assume it will not be working. Could you please update the docker to ensure it is still working fine (use the latest docker image 0.25)?

Sure, but i think it would make sense to make test with the collector (end to end pretty much) itself in our pipeline so this doesn't require manual testing in the future

that would be best, but it would require probably much more effort, but definitely nice to have

[vmarchaud]

I switched back the http port because its really unclear how its supposed to be:

• the spec said that it should be 4317 for both
• but it seems the collector actually didn't get updated
• the collector state in the same document that the port should be 4317 and few lines later 55681

A discussion is still ongoing on the collector side too: open-telemetry/opentelemetry-collector#1256

[vmarchaud]

@obecny Rebased + tested with latest collector version (0.25.0) and its works fine !

[obecny]

lgtm

[johnbley]

lgtm

[vmarchaud]

Friendly ping here too @dyladan :)