Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes after last changes to url #2214

Merged
merged 2 commits into from May 20, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented May 19, 2021

Which problem is this PR solving?

  • Failing tests for grpc collector - after latest changes to normalize url

Short description of the changes

  • fixes for url
  • updated certificates as well
  • normalized config url and environment url

@dyladan
Copy link
Member

dyladan commented May 19, 2021

What was the root of the errors? I'm surprised the URL validation/normalization needed to be moved.

@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #2214 (f862630) into main (24adbd6) will decrease coverage by 0.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   93.68%   92.69%   -0.99%     
==========================================
  Files          53      141      +88     
  Lines        1726     5106    +3380     
  Branches      358     1049     +691     
==========================================
+ Hits         1617     4733    +3116     
- Misses        109      373     +264     
Impacted Files Coverage Δ
...metry-instrumentation-grpc/src/grpc/clientUtils.ts 88.40% <0.00%> (ø)
...exporter-prometheus/src/PrometheusLabelsBatcher.ts 100.00% <0.00%> (ø)
...sources/src/platform/node/detectors/EnvDetector.ts 87.23% <0.00%> (ø)
...strumentation/src/platform/node/instrumentation.ts 23.61% <0.00%> (ø)
...ackages/opentelemetry-metrics/src/BatchObserver.ts 100.00% <0.00%> (ø)
...es/opentelemetry-tracing/src/MultiSpanProcessor.ts 100.00% <0.00%> (ø)
...y-instrumentation-grpc/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...s/opentelemetry-metrics/src/ValueRecorderMetric.ts 100.00% <0.00%> (ø)
...ry-instrumentation-grpc/src/grpc-js/serverUtils.ts 91.66% <0.00%> (ø)
...ces/src/platform/node/detectors/ProcessDetector.ts 100.00% <0.00%> (ø)
... and 82 more

@obecny
Copy link
Member Author

obecny commented May 19, 2021

What was the root of the errors? I'm surprised the URL validation/normalization needed to be moved.

the normalization introduced a new variable whereas the url already existed and tests should always point to one param so this way it can be checked properly (the url is taken form config or environment or default). The environment params weren't normalized and as last something wrong has happened to the certificates, needed to recreate them again.

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing tests! 🎉

@vmarchaud vmarchaud merged commit 1745d87 into open-telemetry:main May 20, 2021
@dyladan dyladan mentioned this pull request Jun 2, 2021
@obecny obecny deleted the ce-fix branch June 3, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants