Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set default service name #2227

Merged
merged 10 commits into from
Jun 1, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 25, 2021

This is an alternative to #2154 and fixes #2143

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #2227 (ec802cf) into main (7fa4ff7) will increase coverage by 0.05%.
The diff coverage is 93.33%.

❗ Current head ec802cf differs from pull request most recent head 8099e9e. Consider uploading reports for the commit 8099e9e to get more accurate results

@@            Coverage Diff             @@
##             main    #2227      +/-   ##
==========================================
+ Coverage   92.23%   92.29%   +0.05%     
==========================================
  Files         143      144       +1     
  Lines        5154     5168      +14     
  Branches     1060     1064       +4     
==========================================
+ Hits         4754     4770      +16     
+ Misses        400      398       -2     
Impacted Files Coverage Δ
...ckages/opentelemetry-core/src/utils/environment.ts 95.83% <ø> (ø)
...ry-exporter-collector/src/CollectorExporterBase.ts 92.15% <ø> (-0.16%) ⬇️
.../opentelemetry-exporter-collector/src/transform.ts 88.69% <ø> (ø)
...lemetry-exporter-collector/src/transformMetrics.ts 95.71% <ø> (ø)
...ages/opentelemetry-exporter-collector/src/types.ts 100.00% <ø> (ø)
...ackages/opentelemetry-exporter-jaeger/src/types.ts 100.00% <ø> (ø)
...ry-resources/src/platform/node/detect-resources.ts 21.73% <ø> (ø)
...sources/src/platform/node/detectors/EnvDetector.ts 88.23% <84.61%> (+1.00%) ⬆️
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 90.90% <94.73%> (+3.40%) ⬆️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <100.00%> (ø)
... and 7 more

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, will approve when the default service name problem has a solution

@dyladan
Copy link
Member Author

dyladan commented May 26, 2021

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about jaeger exporter ?

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add example to readme upgrade guidelines how to define service name for collector exporter now. Other than that lgtm

packages/opentelemetry-exporter-jaeger/src/jaeger.ts Outdated Show resolved Hide resolved
@dyladan dyladan added the enhancement New feature or request label Jun 1, 2021
@dyladan dyladan merged commit 56c032e into open-telemetry:main Jun 1, 2021
@dyladan dyladan deleted the default-service-name-tp branch June 1, 2021 19:07
@dyladan dyladan mentioned this pull request Jun 2, 2021
OmkarKirpan added a commit to OmkarKirpan/opentelemetry-js that referenced this pull request Jun 17, 2021
Since the 0.20.0 release and the pull request open-telemetry#2227 it seems that serviceName is deprecated and we should use service.name instead. I havn't easily found this information in the changelog, it did require some digging to understand why the service name was now a very long unknown_service:/path/to/node. Documentation says use service.name Resource attribute instead. but it wasn't about replacing serviceName: 'yourServiceName' by service: { name: 'yourServiceName'}.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TracerProvider's newly set Resource should have service name set
3 participants