Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to NOOP singletons #2229

Merged
merged 4 commits into from May 27, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 26, 2021

Only references from the production API package were changed. The metrics API can be handled at a later time.

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #2229 (8790d13) into main (d82ad8a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2229      +/-   ##
==========================================
- Coverage   92.25%   92.23%   -0.02%     
==========================================
  Files         143      143              
  Lines        5154     5154              
  Branches     1060     1060              
==========================================
- Hits         4755     4754       -1     
- Misses        399      400       +1     
Impacted Files Coverage Δ
...ges/opentelemetry-instrumentation-http/src/http.ts 95.68% <100.00%> (ø)
packages/opentelemetry-tracing/src/Tracer.ts 67.14% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

@dyladan dyladan merged commit 7fa4ff7 into open-telemetry:main May 27, 2021
@dyladan dyladan deleted the remove-noop-singletons branch May 27, 2021 17:50
@dyladan dyladan mentioned this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants