chore: add node:16 to the test matrix #2244
Conversation
rauno56
requested review from
dyladan,
Flarna,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2244 +/- ##
=======================================
Coverage 92.79% 92.79%
=======================================
Files 144 144
Lines 5178 5178
Branches 1060 1060
=======================================
Hits 4805 4805
Misses 373 373 |
|
Looks like node 16 uses an updated openssl which declares md certificates to be too weak for use. The certificates will need to be regenerated with a stronger algorithm than md5 in order to be accepted by node 16 |
…js into chore/add-node-16
|
I suspect that the remaining error with codecov has to do with credentials. I get the same error locally(no creds) and the http response of the upload request internally inside codecov package is "Could not determine repo and owner" which codecov mistakenly fails to recognize as a failure. EDIT Actually, after another look - it is supposed to switch to another API if that occurs but fails to do that. So that's a bug in |
|
I had a similar issue with codecov in another PR recently. It recovered in a rerun a day after. Update: retriggered actions and new run was green |
|
Their backend seems to be a little flaky sometimes |
| @@ -1,4 +1,4 @@ | |||
| #! /bin/sh | |||
| #!/usr/bin/env sh | |||
There was a problem hiding this comment.
Not everyone is going to have a local env.sh
| @@ -1,4 +1,4 @@ | |||
| #! /bin/sh | |||
| #!/usr/bin/env sh | |||
Which problem is this PR solving?
Adds current node version(16) to the test matrix.