feat(@opentelemetry/propagator-jaeger): support custom baggage prefix #2673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
reviewed
Dec 16, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerPropagator.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
- Coverage 92.55% 92.53% -0.02%
==========================================
Files 144 144
Lines 5183 5186 +3
Branches 1104 1106 +2
==========================================
+ Hits 4797 4799 +2
- Misses 386 387 +1
|
sschegolev
force-pushed
the
support-custom-baggage-header-prefix
branch
from
fd18720
to
2d12742
Compare
naseemkullah
approved these changes
Dec 18, 2021
sschegolev
force-pushed
the
support-custom-baggage-header-prefix
branch
from
2d12742
to
9ba00cb
Compare
dyladan
reviewed
Dec 21, 2021
packages/opentelemetry-propagator-jaeger/src/JaegerPropagator.ts
Outdated
Show resolved
Hide resolved
sschegolev
force-pushed
the
support-custom-baggage-header-prefix
branch
from
9ba00cb
to
215a045
Compare
vmarchaud
approved these changes
Dec 25, 2021
dyladan
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds support custom baggage header prefix to make JaegerPropagator API more flexible.