feat: add ConsoleSpanExporter #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
iredelmeier,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
danielkhan
approved these changes
Sep 21, 2019
OlivierAlbertini
approved these changes
Sep 21, 2019
I don't expect users to use ConsoleExporter in the production system. I think creating a hierarchy in the console would be a little tricky job and not sure whether it is worst to spend time on that. WDYT? |
| ): void { | ||
| for (const span of spans) { | ||
| console.log( | ||
| `{name=${span.name}, traceId=${span.spanContext.traceId}, spanId=${ |
There was a problem hiding this comment.
Would it make sense to use the .toString function on Span?
There was a problem hiding this comment.
This is actually ReadableSpan interface. I am not sure how to add methods on the interface
bg451
approved these changes
Sep 23, 2019
markwolff
approved these changes
Sep 24, 2019
lukaswelinder
pushed a commit
to agile-pm/opentelemetry-js
that referenced
this pull request
Jul 24, 2020
…elemetry#303) Signed-off-by: isayme <isaymeorg@gmail.com>
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes