Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update trace-web example and rename it to opentelemetry-web #3145

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Aug 5, 2022

Which problem is this PR solving?

Previously, some of the examples in trace-web were not working, and the metrics packages were outdated, and some buttons were not triggering the creation of a trace.

This PR:

  • renames the trace-web example to opentelemetry-web, since the examples also include metrics.
  • updates the metrics packages to 0.31.0
  • updates the instrumentation packages to 0.31.0
  • fixes button handlers for the fetchXhr and fetchXhrB3 examples.
  • fixes eslint Parsing error: 'import' and 'export' may appear only with 'sourceType: module' by replacing import with require
  • adds docker collector setup with zipkin and prometheus, as well as an npm script to run it.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #3145 (9521683) into main (dc2d093) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3145   +/-   ##
=======================================
  Coverage   93.21%   93.21%           
=======================================
  Files         196      196           
  Lines        6414     6414           
  Branches     1350     1350           
=======================================
  Hits         5979     5979           
  Misses        435      435           

@pichlermarc pichlermarc marked this pull request as ready for review August 5, 2022 12:05
@pichlermarc pichlermarc requested a review from a team as a code owner August 5, 2022 12:05
Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm apart from nits

CHANGELOG.md Outdated Show resolved Hide resolved
@legendecas legendecas merged commit f882b71 into open-telemetry:main Aug 9, 2022
@pichlermarc pichlermarc deleted the chore/update-trace-web branch August 10, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants