Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge ts project references to tsconfig.json #3169

Closed

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Aug 16, 2022

Which problem is this PR solving?

Merge ts project references to the package's root tsconfig.json so that

  1. compile a single project (in their own directory, run npm run compile) can also compile their dependencies esm/esnext targets.
  2. compile at the lerna root directory (run npm run compile at the project's root) can also compile all packages' targets.

Short description of the changes

  1. use tsconfig.json as the true single entrypoint for a ts project.
  2. add script scripts/update-ts-references.js to replace the package update-ts-references for our own use case.

Type of change

  • Internal change

Checklist:

  • Followed the style guidelines of this project

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Oct 17, 2022
@legendecas
Copy link
Member Author

Closing, merging the sub-tsconfigs with the entry project references can confuse tsc about the project dependencies order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant