Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run browser tests without circle #3328

Merged
merged 8 commits into from Oct 14, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 13, 2022

The circle ci image we've been using for testing was causing permissions issues in github actions. This was the original reason for the permission setting in the action run. Chrome has since been added to the default runner so we actually don't need the image at all.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3328 (1aeac5a) into main (aa263e5) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3328      +/-   ##
==========================================
+ Coverage   93.43%   93.45%   +0.01%     
==========================================
  Files         241      241              
  Lines        7253     7253              
  Branches     1507     1507              
==========================================
+ Hits         6777     6778       +1     
+ Misses        476      475       -1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@dyladan dyladan marked this pull request as ready for review October 13, 2022 15:42
@dyladan dyladan requested a review from a team as a code owner October 13, 2022 15:42
@dyladan
Copy link
Member Author

dyladan commented Oct 13, 2022

@open-telemetry/javascript-approvers since the recent release of actions/core this PR is blocking all other PRs so please approve ASAP

@legendecas
Copy link
Member

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 🙂
It's good to have a permanent fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that the web build is compatible with actions/checkout versions >= 3.1.0
3 participants