update target to ensure compilation does not alter generated code #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
requested review from
danielkhan,
iredelmeier,
justindsmith and
mayurkale22
as code owners
rochdev
force-pushed
the
tsconfig-only-types
branch
from
c4af8eb
to
70803fe
Compare
iredelmeier
approved these changes
Jun 14, 2019
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the TypeScript compilation target to the latest possible ECMAScript standard to ensure that the JavaScript output is not altered by the compiler. This will ensure that the generated JavaScript code is the same as the TypeScript code minus types.
The reasoning behind this has been discussed previously, but the short version is to avoid being unable to test certain features because they have been transpiled to something else.