Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tsconfig): abort on invalid json content #3578

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Fixes #3566 (comment)

Also,

  • renames root tsconfig.es5.json to be tsconfig.base.es5.json as it is not an entry tsconfig.
  • moves root style.md to doc/contributing to reduce the number of files in the root directory.

Type of change

  • Internal cleanup

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas requested a review from a team as a code owner January 31, 2023 03:53
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Merging #3578 (6d7b6e9) into main (2a76d88) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3578   +/-   ##
=======================================
  Coverage   93.90%   93.90%           
=======================================
  Files         255      255           
  Lines        7763     7763           
  Branches     1613     1613           
=======================================
  Hits         7290     7290           
  Misses        473      473           

@dyladan dyladan merged commit 2b59c28 into open-telemetry:main Jan 31, 2023
@legendecas legendecas deleted the tsconfig branch February 1, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants