Rename Diag/LoggerOptions to DiagLoggerOptions

[altinokdarici]

Which problem is this PR solving?

Conflicting type name LoggerOptions in API and experimental logs API

Fixes #3640

Short description of the changes

Renaming LoggerOptions to DiagLoggerOptions

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

N/A

Checklist:

• Followed the style guidelines of this project
• Unit tests have been added
• Documentation has been updated

[codecov]

Codecov Report

Merging #3641 (f72bde9) into main (0d373bd) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head f72bde9 differs from pull request most recent head 54492a2. Consider uploading reports for the commit 54492a2 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3641      +/-   ##
==========================================
+ Coverage   93.52%   93.72%   +0.19%     
==========================================
  Files         271      274       +3     
  Lines        7496     8058     +562     
  Branches     1521     1670     +149     
==========================================
+ Hits         7011     7552     +541     
- Misses        485      506      +21     

Impacted Files	Coverage Δ
api/src/diag/types.ts	100.00% <ø> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts	87.50% <0.00%> (-6.25%)	⬇️
...es/opentelemetry-instrumentation-http/src/utils.ts	99.18% <0.00%> (ø)
...ges/opentelemetry-instrumentation-http/src/http.ts	94.26% <0.00%> (ø)
...y-instrumentation-http/src/enums/AttributeNames.ts	100.00% <0.00%> (ø)

[pichlermarc]

Thanks for taking care of this. 🙂
Should be safe to change, looks like this type is indeed not exported. 🙂

[altinokdarici]

@Flarna, @pichlermarc thanks for approval. How can I get this PR merged?

[pichlermarc]

We usually keep it open for some time (1-2 days from opening the PR) so everyone can have a look, then we'll merge it if approved. No actions are necessary except for the occasional branch update. 🙂

[dyladan]

There's been enough reviews I think to merge this without waiting

[dyladan]

One question is why is the type not exposed? It looks like in the diag API the type isn't used where it should be in src/api/diag.ts DiagAPI#setLogger

[Flarna]

see #3639 where I notices the name conflict resulting in #3640 and finally this PR.