Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): add example/http to ignore list in update-ts-configs #3657

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

llc1123
Copy link
Contributor

@llc1123 llc1123 commented Mar 7, 2023

Which problem is this PR solving?

npm install fails on update-ts-configs

> node scripts/update-ts-configs.js

node:internal/fs/utils:346
    throw err;
    ^

Error: ENOENT: no such file or directory, open '/workspaces/opentelemetry-js/examples/http/tsconfig.json'
    at Object.openSync (node:fs:585:3)
    at Object.readFileSync (node:fs:453:35)
    at readJSON (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:281:26)
    at readAndMaybeMergeTsConfig (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:250:20)
    at writeSingleTargetTsConfig (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:148:14)
    at generateTsConfig (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:95:3)
    at main (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:76:5)
    at Object.<anonymous> (/workspaces/opentelemetry-js/scripts/update-ts-configs.js:67:1)
    at Module._compile (node:internal/modules/cjs/loader:1246:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1300:10) {
  errno: -2,
  syscall: 'open',
  code: 'ENOENT',
  path: '/workspaces/opentelemetry-js/examples/http/tsconfig.json'
}

Short description of the changes

Adds example/http to the ignore list.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Remove node_modules and package-lock.json. Rerun npm install.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@llc1123 llc1123 requested a review from a team as a code owner March 7, 2023 07:47
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 7, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: llc1123 / name: 粒粒橙 (bc36b5c)

@llc1123 llc1123 changed the title fix(build): fix npm install error fix(build): add example/http to ignore list in update-ts-configs Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3657 (8ba12a9) into main (3a2ca58) will increase coverage by 0.72%.
The diff coverage is n/a.

❗ Current head 8ba12a9 differs from pull request most recent head 62c8da0. Consider uploading reports for the commit 62c8da0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3657      +/-   ##
==========================================
+ Coverage   92.92%   93.65%   +0.72%     
==========================================
  Files         268      275       +7     
  Lines        7622     8095     +473     
  Branches     1595     1682      +87     
==========================================
+ Hits         7083     7581     +498     
+ Misses        539      514      -25     
Impacted Files Coverage Δ
...-trace-base/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️
...s/opentelemetry-instrumentation-fetch/src/fetch.ts 97.02% <0.00%> (ø)
...emetry-instrumentation-xml-http-request/src/xhr.ts 97.59% <0.00%> (ø)
...es/opentelemetry-context-zone-peer-dep/src/util.ts 100.00% <0.00%> (ø)
...ation-xml-http-request/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...ry-context-zone-peer-dep/src/ZoneContextManager.ts 85.00% <0.00%> (ø)
...mentation-xml-http-request/src/enums/EventNames.ts 100.00% <0.00%> (ø)
...-instrumentation-fetch/src/enums/AttributeNames.ts 100.00% <0.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️
packages/opentelemetry-sdk-trace-web/src/utils.ts 95.03% <0.00%> (+29.19%) ⬆️

Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙂

@pichlermarc
Copy link
Member

@llc1123 looks like your commit is not signed and you have vigilant mode on - do you want to sign it?

@llc1123
Copy link
Contributor Author

llc1123 commented Mar 7, 2023

@llc1123 looks like your commit is not signed and you have vigilant mode on - do you want to sign it?

Oh, sorry. I was using codespaces and missed it. Fixed now.

@pichlermarc
Copy link
Member

@llc1123 Amazing, thanks :)

@pichlermarc pichlermarc merged commit 95bf6fc into open-telemetry:main Mar 7, 2023
@llc1123 llc1123 deleted the fix/install-scripts branch April 14, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants