Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use npx to run tsc 4.4.4 in api-eol-node-test #3700

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Mar 24, 2023

Which problem is this PR solving?

api-eol-node-test is failing as it uses typescript 5.0.2 to compile tests.
This PR changes the job to use the typescript version from package.json to compile the API & tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • internal

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@pichlermarc
Copy link
Member Author

This should fix the failures in seen in #3699 and #3696

@pichlermarc pichlermarc marked this pull request as ready for review March 24, 2023 11:03
@pichlermarc pichlermarc requested a review from a team as a code owner March 24, 2023 11:03
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #3700 (8b8b1be) into main (0c37daa) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 8b8b1be differs from pull request most recent head 65d21a6. Consider uploading reports for the commit 65d21a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3700      +/-   ##
==========================================
- Coverage   93.70%   93.68%   -0.02%     
==========================================
  Files         277      277              
  Lines        8446     8446              
  Branches     1753     1753              
==========================================
- Hits         7914     7913       -1     
- Misses        532      533       +1     

see 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants