Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exporter-logs-otlp-http): implements otlp-http exporters for logs #3755

Closed
wants to merge 29 commits into from
Closed

feat(exporter-logs-otlp-http): implements otlp-http exporters for logs #3755

wants to merge 29 commits into from

Conversation

momenthana
Copy link

@momenthana momenthana commented Apr 25, 2023

Which problem is this PR solving?

Extend to http for #3712
I needed work to ensure browser sdk usage for the above PR!

For logs in grafana
스크린샷 2023-04-25 오후 2 02 10

  • exporter-logs-otlp-http

Short description of the changes

  • Added new package exporter-logs-otlp-http

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run the included unit tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #3755 (749e223) into main (9347ca6) will decrease coverage by 2.27%.
The diff coverage is n/a.

❗ Current head 749e223 differs from pull request most recent head 2a58c6f. Consider uploading reports for the commit 2a58c6f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3755      +/-   ##
==========================================
- Coverage   93.39%   91.13%   -2.27%     
==========================================
  Files         290       82     -208     
  Lines        8863     1794    -7069     
  Branches     1838      362    -1476     
==========================================
- Hits         8278     1635    -6643     
+ Misses        585      159     -426     

see 214 files with indirect coverage changes

@fuaiyi
Copy link
Contributor

fuaiyi commented Apr 26, 2023

Thank you for your contribution, but I'm sorry to say that the development of OTLP-HTTP-Exporter has already been completed in 3442. However, due to the large amount of code, it was split into 2 PRs. The SDK part was merged a few days ago, and I haven't had a chance to submit a PR for the OTLP-HTTP-Exporter part yet, I will do it tomorrow.

@fuaiyi
Copy link
Contributor

fuaiyi commented Apr 26, 2023

Thank you for your contribution, but I'm sorry to say that the development of OTLP-HTTP-Exporter has already been completed in 3442. However, due to the large amount of code, it was split into 2 PRs. The SDK part was merged a few days ago, and I haven't had a chance to submit a PR for the OTLP-HTTP-Exporter part yet, I will do it tomorrow.

I have submitted pr #3764, and you are very welcome to participate in CR.

@momenthana
Copy link
Author

momenthana commented Apr 27, 2023

ok. I will contribute when the merge for the #3764 PR proceeds.
I've confirmed that "export-logs-otlp-http" should be preceded for "export-logs-otlp-proto" and contributed
For use with test case and util

@momenthana momenthana closed this May 30, 2023
@momenthana momenthana deleted the feat/logging-otlp-http branch May 30, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants