Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v8.43.0 #3929

Merged

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented Jun 20, 2023

Which problem is this PR solving?

Updates eslint to v8.43.0. eslint now defaults to use the new flat config if a "flat" config file (a file called eslint.config.js) is present, which causes eslint to fail if the configuration file does not follow the new format.. However, our "old" file is using that same name and that causes eslint to not accept --ext anymore. (see also eslint/eslint#16531)

This PR updates eslint and renames the top-level config file to a non-reserved name to prevent eslint from assuming we're using the new "flat" configuration.

Based on / Supersedes #3916

Type of change

  • internal

How Has This Been Tested?

  • ran eslint locally

@pichlermarc pichlermarc added dependencies Pull requests that update a dependency file internal labels Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #3929 (17c5493) into main (06e919d) will increase coverage by 0.06%.
The diff coverage is n/a.

❗ Current head 17c5493 differs from pull request most recent head abdddab. Consider uploading reports for the commit abdddab to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3929      +/-   ##
==========================================
+ Coverage   93.07%   93.14%   +0.06%     
==========================================
  Files         250      298      +48     
  Lines        7627     8868    +1241     
  Branches     1567     1826     +259     
==========================================
+ Hits         7099     8260    +1161     
- Misses        528      608      +80     

see 51 files with indirect coverage changes

@pichlermarc pichlermarc marked this pull request as ready for review June 20, 2023 12:50
@pichlermarc pichlermarc requested a review from a team as a code owner June 20, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants