Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(resources): Fixes detectResources deprecated typos #4003

Merged
merged 2 commits into from
Aug 3, 2023
Merged

docs(resources): Fixes detectResources deprecated typos #4003

merged 2 commits into from
Aug 3, 2023

Conversation

HPaulson
Copy link
Contributor

The deprecated message for detectResources suggests to use detectResourceSync() instead, when the real method is called detectResourcesSync() (Resources is plural)

@HPaulson HPaulson requested a review from a team as a code owner July 18, 2023 15:32
@pichlermarc pichlermarc added document Documentation-related Skip Changelog labels Aug 3, 2023
pichlermarc
pichlermarc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 🙂

@pichlermarc pichlermarc changed the title Fixes detectResources deprecated typos docs(resources): Fixes detectResources deprecated typos Aug 3, 2023
@pichlermarc pichlermarc merged commit 5fd656b into open-telemetry:main Aug 3, 2023
15 checks passed
@sumodgeorge sumodgeorge mentioned this pull request Aug 9, 2023
Open
This was referenced Nov 27, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees
No one assigned
Labels
document Documentation-related Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HPaulson @pichlermarc