Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lerna): add lerna-changelog #432

Merged
merged 2 commits into from
Oct 16, 2019
Merged

chore(lerna): add lerna-changelog #432

merged 2 commits into from
Oct 16, 2019

Conversation

OlivierAlbertini
Copy link
Member

Which problem is this PR solving?

Short description of the changes

  • add docs related to lerna-changelog
  • add lerna-changelog package
  • modify lerna.json

@codecov-io
Copy link

codecov-io commented Oct 15, 2019 •
edited
Loading

Codecov Report

Merging #432 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #432      +/-   ##
==========================================
+ Coverage   95.81%   95.87%   +0.06%     
==========================================
  Files         108      108              
  Lines        5278     5315      +37     
  Branches      433      428       -5     
==========================================
+ Hits         5057     5096      +39     
+ Misses        221      219       -2
Impacted Files Coverage Δ
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-plugin-http/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 60% <0%> (+2.85%) ⬆️
...es/opentelemetry-node/src/instrumentation/utils.ts 96% <0%> (+5.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0626c...7219008. Read the comment docs.

mayurkale22
mayurkale22 approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

draffensperger
draffensperger reviewed Oct 16, 2019
View reviewed changes
Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

RELEASING.md Outdated
Pass your github token to generate the changelog automatically.
In your terminal, execute the following command:
```bash
GITHUB_AUTH=xxxxx lerna-changelog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this require a GitHub token? I would have expected it to be able to get the commit info simply from the git history, or is it pulling pull request info as well?

Could we at least ask people to use a read-only token?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this require a GitHub token?

For rate limiting issues. Sadly, it's required...

or is it pulling pull request info as well?

It will use pull request info

Also, it will print changelog for PR that have been labelled (see lerna.json)

Could we at least ask people to use a read-only token?

Yes. Good idea.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense!

@OlivierAlbertini
chore(lerna): add lerna-changelog
ac89273 
closes open-telemetry#372
add docs related to lerna-changelog

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@OlivierAlbertini
fix: add draffensperger recommendations
7219008 
Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
@mayurkale22 mayurkale22 merged commit ddf43ff into open-telemetry:master Oct 16, 2019
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
@dyladan
chore(lerna): add lerna-changelog (open-telemetry#432)
f53bb82 
* chore(lerna): add lerna-changelog

closes open-telemetry#372
add docs related to lerna-changelog

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>

* fix: add draffensperger recommendations

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@seemk
feat: pino instrumentation (open-telemetry#432)
60dd7d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draffensperger draffensperger draffensperger left review comments

@danielkhan danielkhan danielkhan approved these changes

@vmarchaud vmarchaud vmarchaud approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@bg451 bg451 Awaiting requested review from bg451

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@rochdev rochdev Awaiting requested review from rochdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[lerna] changelog management
6 participants
@OlivierAlbertini @codecov-io @danielkhan @vmarchaud @draffensperger @mayurkale22