Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CONTRIBUTING.md #445

Merged

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • Update CONTRIBUTING.md with how to run benchmarks.

@codecov-io
Copy link

Codecov Report

Merging #445 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #445      +/-   ##
==========================================
+ Coverage   95.32%   95.41%   +0.08%     
==========================================
  Files         124      124              
  Lines        6166     6171       +5     
  Branches      505      510       +5     
==========================================
+ Hits         5878     5888      +10     
+ Misses        288      283       -5
Impacted Files Coverage Δ
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
...in-dns/test/integrations/dnspromise-lookup.test.ts 90.82% <0%> (+0.91%) ⬆️
packages/opentelemetry-plugin-dns/src/utils.ts 70% <0%> (+1%) ⬆️
...ry-plugin-dns/test/integrations/dns-lookup.test.ts 94.16% <0%> (+1.66%) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 57.14% <0%> (+23.8%) ⬆️

@OlivierAlbertini OlivierAlbertini added the document Documentation-related label Oct 21, 2019
@mayurkale22 mayurkale22 merged commit dc4ed28 into open-telemetry:master Oct 21, 2019
@mayurkale22 mayurkale22 deleted the update_CONTRIBUTING.md branch October 21, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants