fix: allow recording links only at Span creation time #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
iredelmeier,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
commented
Oct 21, 2019
| @@ -41,7 +41,10 @@ function translateSpanOptions( | |||
| startTime: options.startTime, | |||
| }; | |||
|
|
|||
| // because there's no `Links` in SpanOptions, we set them in `TracerShim.startSpan()` | |||
There was a problem hiding this comment.
@bg451 this change will make you (and everyone) very happy :)
Codecov Report
@@ Coverage Diff @@
## master #449 +/- ##
==========================================
- Coverage 95.32% 95.31% -0.02%
==========================================
Files 124 124
Lines 6166 6064 -102
Branches 505 509 +4
==========================================
- Hits 5878 5780 -98
+ Misses 288 284 -4
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Oct 22, 2019
mayurkale22
force-pushed
the
remove-add_link
branch
from
0331c3e
to
a2b91e7
Compare
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Co-authored-by: vmarchaud <vmarchaud@users.noreply.github.com>
martinkuba
pushed a commit
to martinkuba/opentelemetry-js
that referenced
this pull request
Mar 13, 2024
Co-authored-by: vmarchaud <vmarchaud@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Links will be recorded only during the start
Spanoperation, because:SampledFlagcan be used in the sampling decision.Spancreation.