-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(instrumentation-http): remove obvious temp allocations #4576
Merged
pichlermarc
merged 3 commits into
open-telemetry:main
from
Samuron:instrumentation_http_alloc
Mar 29, 2024
Merged
perf(instrumentation-http): remove obvious temp allocations #4576
pichlermarc
merged 3 commits into
open-telemetry:main
from
Samuron:instrumentation_http_alloc
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2f61558
to
b1adb07
Compare
MSNev
approved these changes
Mar 27, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4576 +/- ##
==========================================
+ Coverage 92.84% 92.86% +0.01%
==========================================
Files 328 328
Lines 9496 9499 +3
Branches 2042 2042
==========================================
+ Hits 8817 8821 +4
+ Misses 679 678 -1
|
pichlermarc
approved these changes
Mar 28, 2024
pichlermarc
reviewed
Mar 28, 2024
This was referenced May 28, 2024
Open
This was referenced Jun 12, 2024
This was referenced Jun 14, 2024
This was referenced Jun 30, 2024
This was referenced Jul 3, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Global warming
Fixes # (issue)
Short description of the changes
Remove some obvious temp objects allocations from instrumentation-http. With
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: