Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing coverage for karma using istanbul #466

Merged
merged 2 commits into from Nov 1, 2019

Conversation

@obecny
Copy link
Member

obecny commented Oct 30, 2019

Which problem is this PR solving?

  1. Fixes #455

Short description of the changes

Fixing coverage tests with karma

@dyladan
dyladan approved these changes Nov 1, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #466 into master will increase coverage by 0.24%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #466      +/-   ##
=========================================
+ Coverage   95.06%   95.3%   +0.24%     
=========================================
  Files         132     136       +4     
  Lines        6782    6926     +144     
  Branches      568     597      +29     
=========================================
+ Hits         6447    6601     +154     
+ Misses        335     325      -10
Impacted Files Coverage Δ
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-5.53%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 57.14% <0%> (-2.86%) ⬇️
packages/opentelemetry-metrics/src/Utils.ts 100% <0%> (ø) ⬆️
...try-node/test/instrumentation/PluginLoader.test.ts 100% <0%> (ø) ⬆️
...opentelemetry-plugin-http/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/types.ts
...es/opentelemetry-plugin-document-load/src/utils.ts 100% <0%> (ø)
...y-plugin-document-load/src/enums/AttributeNames.ts 100% <0%> (ø)
...ackages/opentelemetry-web/src/StackScopeManager.ts 100% <0%> (ø)
...-document-load/src/enums/PerformanceTimingNames.ts 100% <0%> (ø)
... and 6 more
@mayurkale22 mayurkale22 merged commit ae904d5 into open-telemetry:master Nov 1, 2019
8 checks passed
8 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.