Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(sdk-trace-node): support xray propagator (#4602)" #4727

Merged
merged 5 commits into from
May 23, 2024

Conversation

pichlermarc
Copy link
Member

@pichlermarc pichlermarc commented May 22, 2024

This reverts commit 75d88f7.

Which problem is this PR solving?

According to the specification, we MUST NOT maintain the aws and aws-lambda propagators as part of the core repo, therefore we also cannot have it be a dependency of @opentelemetry/sdk-trace-node.

Therefore this PR reverts #4602 (unreleased)

To replace this feature, I plan to introduce a getPropagator() function, which uses OTEL_PROPAGATORS to build a propagator based on its value, see open-telemetry/opentelemetry-js-contrib#2232

@pichlermarc pichlermarc marked this pull request as ready for review May 22, 2024 15:34
@pichlermarc pichlermarc requested a review from a team as a code owner May 22, 2024 15:34
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof. Does this mean that the @opentelemetry/propagator-aws-xray pacakge should move back to the contrib repo?

Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking for posterity, since I found myself looking for it and others may as well. We had suggested as a follow-up to reconsider the spec guidelines for xray and it was rejected. The getPropagators option sounds like the best move forward anyway.

@pichlermarc
Copy link
Member Author

Oof. Does this mean that the @opentelemetry/propagator-aws-xray pacakge should move back to the contrib repo?

Yes, that'd be the next step. We can transfer it back to the contrib repo, and we'd have to do the same to @opentelemetry/propagator-aws-xray-lambda and then we're spec compliant again. Looking at it from a long-term perspective, adding all propagators to the @opentelemetry/sdk-trace-node package was not going to be a sustainable solution.

The proposed approach above comes a bit closer to what I think we should do in the future (full separation of env var configuration from core SDK packages (sdk-metrics, sdk-logs, sdk-trace) into an autoconfigure component)

@pichlermarc pichlermarc merged commit c97f21f into open-telemetry:main May 23, 2024
17 of 18 checks passed
@pichlermarc pichlermarc deleted the revert-4602 branch May 24, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants