Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin): postgres-pool plugin skeleton #473

Merged

Conversation

xiao-lix
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add postgres-pool plugin skeleton, update structure of postgres-plugin folder

@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #473 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   95.31%   95.26%   -0.05%     
==========================================
  Files         137      137              
  Lines        6973     6870     -103     
  Branches      596      596              
==========================================
- Hits         6646     6545     -101     
+ Misses        327      325       -2
Impacted Files Coverage Δ
...opentelemetry-base/test/resources/resource.test.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-zipkin/test/transform.test.ts 100% <0%> (ø) ⬆️
...-plugin-postgres/opentelemetry-plugin-pg/src/pg.ts 91.37% <0%> (ø)
...n-postgres/opentelemetry-plugin-pg/test/pg.test.ts 94.29% <0%> (ø)
...res/opentelemetry-plugin-pg/test/assertionUtils.ts 96.55% <0%> (ø)
...ugin-postgres/opentelemetry-plugin-pg/src/utils.ts 97.01% <0%> (ø)
...ugin-postgres/opentelemetry-plugin-pg/src/enums.ts 100% <0%> (ø)
... and 3 more

@dyladan
Copy link
Member

dyladan commented Oct 31, 2019

I believe that the new sub packages you created are no longer referenced by the lerna.json file. You will need to add packages/opentelemetry-plugin-postgres/* to the packages list.

If someone with more lerna experience could confirm/deny this I would appreciate it

@OlivierAlbertini OlivierAlbertini added the document Documentation-related label Oct 31, 2019
@mayurkale22
Copy link
Member

I believe that the new sub packages you created are no longer referenced by the lerna.json file. You will need to add packages/opentelemetry-plugin-postgres/* to the packages list.

If someone with more lerna experience could confirm/deny this I would appreciate it

Maybe related to lerna/lerna#1191

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mayurkale22
Copy link
Member

@open-telemetry/javascript-approvers Please review and approve.

@mayurkale22 mayurkale22 merged commit 2bfa6c0 into open-telemetry:master Nov 5, 2019
@xiao-lix xiao-lix deleted the xiao/postgres-pool-plugin branch November 15, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants