Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add shutdown method on MetricExporter interface #475

Merged
merged 3 commits into from
Nov 3, 2019

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Nov 1, 2019

Which problem is this PR solving?

/cc @danielkhan

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

Merging #475 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #475   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files         137      137           
  Lines        7003     7003           
  Branches      598      598           
=======================================
  Hits         6679     6679           
  Misses        324      324
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/export/types.ts 100% <ø> (ø) ⬆️

@danielkhan danielkhan merged commit a382767 into open-telemetry:master Nov 3, 2019
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MetricsExporter interface
3 participants