Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples/esm-http-ts): use new exported string constants for semconv #4758

Merged
merged 5 commits into from
Jun 5, 2024
Merged

refactor(examples/esm-http-ts): use new exported string constants for semconv #4758

merged 5 commits into from
Jun 5, 2024

Conversation

Zen-cronic
Copy link
Contributor

Which problem is this PR solving?

Updates #4567

Short description of the changes

Replaced deprecated import (SemanticResourceAttributes) from @opentelemetry/semantic-conventions with new string constants (SEMRESATTRS_SERVICE_NAME) for the example esm-http-ts package

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • npm test

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@Zen-cronic Zen-cronic requested a review from a team as a code owner June 4, 2024 13:29
JamieDanielson
JamieDanielson approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry? I'm not sure why the Node14 test is failing, perhaps it is flaky and will pass on the next commit. Will take a look if it fails again.

@JamieDanielson JamieDanielson mentioned this pull request Jun 4, 2024
Open
24 tasks
@pichlermarc pichlermarc changed the title refactor(examples/ems-http-ts): use new exported string constants for semconv refactor(examples/esm-http-ts): use new exported string constants for semconv Jun 5, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Jun 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 5, 2024
@pichlermarc pichlermarc added this pull request to the merge queue Jun 5, 2024
Merged via the queue into open-telemetry:main with commit 957fa3b Jun 5, 2024
19 checks passed
@pichlermarc pichlermarc mentioned this pull request Jun 5, 2024
Merged
This was referenced Jun 27, 2024
Merged
Merged
Merged
@AlexOnyi AlexOnyi mentioned this pull request Jun 30, 2024
Open
@moishimwe moishimwe mentioned this pull request Jun 30, 2024
Open
@marcelineepi marcelineepi mentioned this pull request Jun 30, 2024
Open
@keemraheem keemraheem mentioned this pull request Jun 30, 2024
Open
@jcbadeoye jcbadeoye mentioned this pull request Jun 30, 2024
Open
This was referenced Jun 30, 2024
Open
Open
This was referenced Jul 3, 2024
Closed
Closed
Closed
This was referenced Jul 3, 2024
Closed
Closed
@fakure2020 fakure2020 mentioned this pull request Jul 3, 2024
Open
This was referenced Jul 4, 2024
Closed
Closed
Closed
Closed
Closed
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pichlermarc pichlermarc pichlermarc approved these changes

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zen-cronic @pichlermarc @JamieDanielson