Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to add @obecny as the CODEOWNERS. #505

Merged
merged 2 commits into from Nov 8, 2019

Conversation

@mayurkale22
Copy link
Contributor

mayurkale22 commented Nov 7, 2019

Which problem is this PR solving?

  • @obecny has showed strong interest and commitment in the OpenTelemetry Web SDKs and Plugins. Currently, he is the main contributor for Web SDKs. We really appreciate his work! Thank you for all the contributions.

  • Notable PRs #334, #461, #477, #433, #455, #447, #435, #438.

  • Involved in SIG meetings.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #505 into master will increase coverage by 4.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   88.54%   92.68%   +4.13%     
==========================================
  Files         116      135      +19     
  Lines        5561     6682    +1121     
  Branches      502      596      +94     
==========================================
+ Hits         4924     6193    +1269     
+ Misses        637      489     -148
Impacted Files Coverage Δ
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 90.9% <0%> (-3.21%) ⬇️
...telemetry-core/src/context/propagation/B3Format.ts 95.83% <0%> (-1.31%) ⬇️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
... and 49 more
Copy link
Member

bogdandrutu left a comment

You probably need to add them to the list of approvers and in the approver team

@dyladan
dyladan approved these changes Nov 8, 2019
@mayurkale22 mayurkale22 force-pushed the mayurkale22:new_codeowner branch from 7ba0063 to 7dc2ed5 Nov 8, 2019
@mayurkale22

This comment has been minimized.

Copy link
Contributor Author

mayurkale22 commented Nov 8, 2019

You probably need to add them to the list of approvers and in the approver team

Sure, done.

mayurkale22 added 2 commits Nov 7, 2019
@mayurkale22 mayurkale22 force-pushed the mayurkale22:new_codeowner branch from 7dc2ed5 to 19b1bbe Nov 8, 2019
@mayurkale22 mayurkale22 merged commit f5801d2 into open-telemetry:master Nov 8, 2019
6 checks passed
6 checks passed
ci/circleci: lint_&_docs Your tests passed on CircleCI!
Details
ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node12 Your tests passed on CircleCI!
Details
ci/circleci: node12-browsers Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/linuxfoundation mayurkale22 authorized
Details
@mayurkale22 mayurkale22 deleted the mayurkale22:new_codeowner branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.