Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose to add @obecny as the CODEOWNERS. #505

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Nov 7, 2019

Which problem is this PR solving?

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #505 into master will increase coverage by 4.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   88.54%   92.68%   +4.13%     
==========================================
  Files         116      135      +19     
  Lines        5561     6682    +1121     
  Branches      502      596      +94     
==========================================
+ Hits         4924     6193    +1269     
+ Misses        637      489     -148
Impacted Files Coverage Δ
...ges/opentelemetry-core/src/common/ConsoleLogger.ts 90.9% <0%> (-3.21%) ⬇️
...telemetry-core/src/context/propagation/B3Format.ts 95.83% <0%> (-1.31%) ⬇️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...core/src/context/propagation/NoopHttpTextFormat.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
...ry-tracing/test/export/SimpleSpanProcessor.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
... and 49 more

Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to add them to the list of approvers and in the approver team

@mayurkale22
Copy link
Member Author

You probably need to add them to the list of approvers and in the approver team

Sure, done.

@mayurkale22 mayurkale22 merged commit f5801d2 into open-telemetry:master Nov 8, 2019
@mayurkale22 mayurkale22 deleted the new_codeowner branch November 8, 2019 21:58
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
* chore: add @obecny in CODEOWNERS

* chore: update approvers list
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants