ci: enumerate caching paths manually

[dyladan]

Which problem is this PR solving?

• Fix circleci caching paths #513
• Drastic build total time reduction (from 15+ minutes to under 5)

Short description of the changes

• Manually enumerate node_modules and yarn.lock files for caching paths
• Cache paths for browser builds as well

[codecov-io]

Codecov Report

Merging #514 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   90.39%   90.34%   -0.05%     
==========================================
  Files         144      142       -2     
  Lines        7277     7222      -55     
  Branches      643      641       -2     
==========================================
- Hits         6578     6525      -53     
+ Misses        699      697       -2

Impacted Files	Coverage Δ
...res/opentelemetry-plugin-pg/test/assertionUtils.ts	96.29% <0%> (-3.71%)	⬇️
...core/src/context/propagation/BinaryTraceContext.ts	96.72% <0%> (-1.62%)	⬇️
...ges/opentelemetry-exporter-zipkin/src/transform.ts	100% <0%> (ø)	⬆️
...telemetry-plugin-grpc/test/utils/assertionUtils.ts	100% <0%> (ø)	⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts	100% <0%> (ø)	⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts	100% <0%> (ø)	⬆️
.../opentelemetry-core/src/trace/spancontext-utils.ts	100% <0%> (ø)	⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts	100% <0%> (ø)	⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts	100% <0%> (ø)	⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts	100% <0%> (ø)	⬆️
... and 9 more

[dyladan]

NOT READY FOR MERGE

edit: good to go now

[dyladan]

Tests are way faster with this change. PTAL.

Anyone know why lint would fail when all that changed was the caching strategy? Lint passes on my local

[dyladan]

Caching resources for browser builds now too. Total build time is now under 5 minutes.

[vmarchaud]

LGTM, i don't know if it's possible but we could try to automate the enumeration (using lerna list) of all packages so we don't forget to add them there.

[dyladan]

LGTM, i don't know if it's possible but we could try to automate the enumeration (using lerna list) of all packages so we don't forget to add them there.

Unfortunately no it isn't possible. Each path has to be manually entered into the paths array. There are a number of issues open with circle ci to remedy the issue but we probably have to wait for circle config 3.0 for that.

[dyladan]

@vmarchaud @bg451 @markwolff and those yet to review, do you think we should remove the yarn.lock files from the cache? Right now the lock files are cached between test runs, and only can change if the package.lock checksums change. That means the CI server might not be running with the latest patch versions of our dependencies. Removal will make the test run slightly slower (a few seconds).

Prior to this change nothing was cached, so this would not be different behavior to what we're already used to.

[mayurkale22]

LGTM, added a minor comment

[dyladan]

@mayurkale22 I think everything is resolved here. afaik this is ready for merge

[mayurkale22]

@mayurkale22 I think everything is resolved here. afaik this is ready for merge

Somehow, all dependencies are getting installed for each job => https://circleci.com/workflow-run/5e613ca4-ce88-4529-87f6-3cdcba5c6496. Could you please verify the behavior?