Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples(tracing): add multi exporter example #537

Merged
merged 2 commits into from
Nov 19, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

@mayurkale22
Copy link
Member Author

/cc @naseemkullah

Copy link
Member

@markwolff markwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would we want to expose this in the package.json?

@naseemkullah
Copy link
Member

Thanks @mayurkale22 !

And

// It is recommended to use SimpleSpanProcessor in case of Jaeger exporter as
// it's internal client already handles the spans with batching logic.

is good to know! Should be added to Jaeger Exporter doc if there is any.

@mayurkale22
Copy link
Member Author

LGTM. Would we want to expose this in the package.json?

Good catch, done.

@codecov-io
Copy link

codecov-io commented Nov 14, 2019

Codecov Report

Merging #537 into master will decrease coverage by 2.29%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master     #537     +/-   ##
=========================================
- Coverage    92.4%   90.11%   -2.3%     
=========================================
  Files         152      150      -2     
  Lines        7495     7397     -98     
  Branches      649      661     +12     
=========================================
- Hits         6926     6666    -260     
- Misses        569      731    +162
Impacted Files Coverage Δ
...pentelemetry-core/test/internal/validators.test.ts 50% <0%> (-50%) ⬇️
...elemetry-core/test/trace/spancontext-utils.test.ts 55.55% <0%> (-44.45%) ⬇️
...lemetry-core/test/trace/ProbabilitySampler.test.ts 56.52% <0%> (-43.48%) ⬇️
...s/opentelemetry-core/test/trace/NoopTracer.test.ts 60% <0%> (-40%) ⬇️
...s/opentelemetry-core/test/context/B3Format.test.ts 63.39% <0%> (-36.61%) ⬇️
...ges/opentelemetry-core/test/trace/NoopSpan.test.ts 63.63% <0%> (-36.37%) ⬇️
...s/opentelemetry-core/test/trace/tracestate.test.ts 65.06% <0%> (-34.94%) ⬇️
...ntelemetry-core/test/trace/NoRecordingSpan.test.ts 71.42% <0%> (-28.58%) ⬇️
...ackages/opentelemetry-core/src/platform/node/id.ts 71.42% <0%> (-28.58%) ⬇️
...entelemetry-core/test/common/ConsoleLogger.test.ts 77.01% <0%> (-22.99%) ⬇️
... and 37 more

@mayurkale22
Copy link
Member Author

is good to know! Should be added to Jaeger Exporter doc if there is any.

I found it here, not mentioned in the official docs.

@OlivierAlbertini OlivierAlbertini added the document Documentation-related label Nov 18, 2019
@mayurkale22 mayurkale22 merged commit e8abddb into open-telemetry:master Nov 19, 2019
@mayurkale22 mayurkale22 deleted the multi_exporter branch November 19, 2019 18:47
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
…pen-telemetry#537)

* fix(instrumentation-user-interaction): support clicks in React apps

* chore: code maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide example of export to multiple backends
6 participants